refactor: extract shared filters-lib.sh for filters.ini parsing#63
Open
DmitriiAn wants to merge 1 commit into
Open
refactor: extract shared filters-lib.sh for filters.ini parsing#63DmitriiAn wants to merge 1 commit into
DmitriiAn wants to merge 1 commit into
Conversation
teknogeek0
reviewed
Jun 22, 2026
Contributor
There was a problem hiding this comment.
As a general practice, can we move the shared libs to the top of the shell scripts? helps make them easier to track
Contributor
There was a problem hiding this comment.
Same as other - As a general practice, can we move the shared libs to the top of the shell scripts? helps make them easier to track
Contributor
Author
There was a problem hiding this comment.
Do you mean to keep the filter code from filters-lib.sh in both scripts (verify-migration.sh and preflight-check.sh), but put it at the top instead of having a separate file for that?
I'm okay with that. I just wanted to improve the code base and make the scripts more readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify-migration.shandpreflight-check.shcarried two copies of the samefilters.inilogic with divergent implementations. Move the canonical, column-parameterized implementation from verify-migration.shinto filters-lib.sh and source it from both scripts, so the parsing/scoping logic lives in one place.
No behavior change: preflight's build_schema_where/build_table_filter become schema_clause "n.nspname"/table_clause "n.nspname" "c.relname" (identical SQL), and its exclude-extension awk is replaced by the shared parser's output.
New file filters-lib.sh: the single source of truth, inheriting verify-migration.sh's implementation: